Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1142293004: Revert "Refactor handling of compounds." (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Refactor handling of compounds." This reverts commit e248820e567b. BUG= Committed: https://github.com/dart-lang/sdk/commit/6f6521ccb87420b97f4f246a9cc8019a8d68f5fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4342 lines, -9101 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 16 chunks +821 lines, -192 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 7 chunks +5 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/resolution/access_semantics.dart View 7 chunks +12 lines, -57 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 45 chunks +44 lines, -758 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 65 chunks +3037 lines, -6411 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 6 chunks +15 lines, -134 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 46 chunks +48 lines, -365 lines 0 comments Download
M pkg/compiler/lib/src/resolved_visitor.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 69 chunks +351 lines, -1169 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
TBR
5 years, 7 months ago (2015-05-20 09:35:35 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as 6f6521ccb87420b97f4f246a9cc8019a8d68f5fd (presubmit successful).
5 years, 7 months ago (2015-05-20 09:35:58 UTC) #3
asgerf
5 years, 7 months ago (2015-05-20 11:21:16 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698