Issue 1142283003: Ensure that the ThreadInterrupter is awake after debugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1142283003: Ensure that the ThreadInterrupter is awake after debugging (Closed)

Created:
5 years, 7 months ago by Cutch

Modified:
5 years, 7 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Ensure that the ThreadInterrupter is awake after debugging When possible the ThreadInterrupter enters a deep sleep mode (to conserve CPU usage). We wake the ThreadInterrupter up whenever we schedule an isolate on a thread, but, two edges cases that were not covered: * After explicitly starting an isolate that was paused with --pause-isolates-on-start the thread interrupter may not wake up. * After continuing an isolate that was being single stepped. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/5401622c8a231c4159253520ccd6f3e48482f37e

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	runtime/vm/debugger.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
	M	runtime/vm/message_handler.cc	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

5 years, 7 months ago (2015-05-20 13:49:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
5401622c8a231c4159253520ccd6f3e48482f37e (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1142283003: Ensure that the ThreadInterrupter is awake after debugging (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages