Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 11421221: Allow string juxtapositions in exports. (Closed)

Created:
8 years ago by karlklose
Modified:
8 years ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow string juxtapositions in exports. BUG=dartbug.com/6931 Committed: https://code.google.com/p/dart/source/detail?r=15729

Patch Set 1 #

Patch Set 2 : Add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M sdk/lib/_internal/compiler/implementation/scanner/listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/library_juxtaposition_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
karlklose
8 years ago (2012-12-04 13:05:08 UTC) #1
ahe
I think this allows string interpolation as well. How is this being tested?
8 years ago (2012-12-04 13:08:05 UTC) #2
karlklose
No, this only fixes the types for checked mode. The parser fails on string interpolations ...
8 years ago (2012-12-04 13:36:36 UTC) #3
ahe
8 years ago (2012-12-04 16:28:35 UTC) #4
LGTM!

Powered by Google App Engine
This is Rietveld 408576698