Issue 11421159: Give all async exceptions in pub some sort of stack trace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11421159: Give all async exceptions in pub some sort of stack trace. (Closed)

Created:
8 years ago by nweiz

Modified:
8 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Give all async exceptions in pub some sort of stack trace. Committed: https://code.google.com/p/dart/source/detail?r=15547

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -12 lines)			Patch
M	utils/pub/curl_client.dart	View	2 chunks	+9 lines, -1 line	2 comments	Download
M	utils/pub/io.dart	View	11 chunks	+68 lines, -10 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

I would change the thrown value. Otherwise LGTM. https://codereview.chromium.org/11421159/diff/1/utils/pub/curl_client.dart File utils/pub/curl_client.dart (right): https://codereview.chromium.org/11421159/diff/1/utils/pub/curl_client.dart#newcode141 utils/pub/curl_client.dart:141: throw ...

8 years ago (2012-11-29 22:25:40 UTC) #2

nweiz

8 years ago (2012-11-29 22:39:02 UTC) #3

https://codereview.chromium.org/11421159/diff/1/utils/pub/curl_client.dart
File utils/pub/curl_client.dart (right):

https://codereview.chromium.org/11421159/diff/1/utils/pub/curl_client.dart#ne...
utils/pub/curl_client.dart:141: throw null;
On 2012/11/29 22:25:40, Bob Nystrom wrote:
> Throwing null is forbidden and causes a different kind of exception to be
> thrown. It doesn't really matter much, but I think it would be slightly less
> weird to throw a non-null value. null is the one value in all of Dart that has
> special throw semantics. Maybe throw 'dummy';?

Done.

Expand Messages | Collapse Messages