Issue 11421093: Clean up svn:ignore property and .gitignore in dart, dart/pkg, and dart/runtime.

Issue 11421093: Clean up svn:ignore property and .gitignore in dart, dart/pkg, and dart/runtime. (Closed)

Created:
8 years ago by Bill Hesse

Modified:
8 years ago

Reviewers:
Bob Nystrom, ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Clean up svn:ignore property and .gitignore in dart, dart/pkg, dart/runtime, and dart/samples. Committed: https://code.google.com/p/dart/source/detail?r=15392

Patch Set 3 : #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -135 lines)			Patch
M	dart/.gitignore	View	1 2	1 chunk	+16 lines, -47 lines	1 comment	Download
M	dart/compiler/.gitignore	View	1 2	1 chunk	+28 lines, -21 lines	0 comments	Download
A	dart/pkg/.gitignore	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	dart/runtime/.gitignore	View	1 2	1 chunk	+9 lines, -35 lines	0 comments	Download
M	dart/runtime/bin/net/.gitignore	View	1 2	1 chunk	+8 lines, -13 lines	0 comments	Download
D	dart/samples/.gitignore	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	dart/samples/sample_extension/.gitignore	View	1 2	1 chunk	+9 lines, -2 lines	0 comments	Download
M	dart/utils/apidoc/.gitignore	View	1 2	1 chunk	+20 lines, -7 lines	0 comments	Download
M	dart/utils/compiler/.gitignore	View	1 2	2 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

Thank you, Bill! LGTM https://codereview.chromium.org/11421093/diff/2001/dart/runtime/.gitignore File dart/runtime/.gitignore (right): https://codereview.chromium.org/11421093/diff/2001/dart/runtime/.gitignore#newcode2 dart/runtime/.gitignore:2: /dart-runtime.Makefile How about *.Makefile? https://codereview.chromium.org/11421093/diff/2001/dart/runtime/.gitignore#newcode3 ...

8 years ago (2012-11-27 13:19:53 UTC) #2

ahe

./compiler/dart-compiler.gyp ./compiler/dartium.gyp ./dart.gyp ./pkg/pkg.gyp ./runtime/bin/net/nss.gyp ./runtime/bin/net/sqlite.gyp ./runtime/bin/net/ssl.gyp ./runtime/bin/net/zlib.gyp ./runtime/dart-runtime.gyp ./samples/sample_extension/sample_extension.gyp ./utils/apidoc/apidoc.gyp ./utils/compiler/compiler.gyp

8 years ago (2012-11-27 13:23:04 UTC) #3

Bill Hesse

8 years ago (2012-11-27 14:30:28 UTC) #4

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/11421093/diff/3007/dart/.gitignore
File dart/.gitignore (left):

https://chromiumcodereview.appspot.com/11421093/diff/3007/dart/.gitignore#old...
dart/.gitignore:62: .children
It was a mistake to remove these two.  A .gitignore line that doesn't start with
/ apparently applies to all subdirectories.  We need to add this back.

Expand Messages | Collapse Messages