Issue 11421064: Cleanups and added more checks for valid Integer allocation (must be Smi, Mint or Bigint for their …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11421064: Cleanups and added more checks for valid Integer allocation (must be Smi, Mint or Bigint for their … (Closed)

Created:
8 years, 1 month ago by srdjan

Modified:
8 years ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Cleanups and added more checks for valid Integer allocation (must be Smi, Mint or Bigint for their corresponding range). Integer boxing in compielr seems to check correctly fro smi/mint. Can you think of any other places where we could create incorrect Mints or Bigints? Committed: https://code.google.com/p/dart/source/detail?r=15310

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -31 lines)			Patch
M	runtime/lib/integers.cc	View	1	11 chunks	+26 lines, -16 lines	0 comments	Download
M	runtime/vm/object.h	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	3 chunks	+6 lines, -8 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1	3 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. I think those are the only two places (runtime functions and BoxInteger). https://codereview.chromium.org/11421064/diff/1/runtime/lib/integers.cc File ...

8 years ago (2012-11-26 08:30:58 UTC) #2

srdjan

8 years ago (2012-11-26 16:13:55 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11421064/diff/1/runtime/lib/integers.cc
File runtime/lib/integers.cc (right):

https://codereview.chromium.org/11421064/diff/1/runtime/lib/integers.cc#newco...
runtime/lib/integers.cc:263: Integer& result = Integer::Handle(
On 2012/11/26 08:30:58, Florian Schneider wrote:
> maybe also 
> 
> const Integer&

Done.

https://codereview.chromium.org/11421064/diff/1/runtime/lib/integers.cc#newco...
runtime/lib/integers.cc:279: Integer& result = Integer::Handle(
On 2012/11/26 08:30:58, Florian Schneider wrote:
> const

Done.

Expand Messages | Collapse Messages