Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 11421060: Improve measuring (Closed)

Created:
8 years, 1 month ago by ahe
Modified:
8 years ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org, kasperl, Johnni Winther
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -38 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart View 1 2 chunks +23 lines, -16 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/compiler.dart View 1 6 chunks +37 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
8 years, 1 month ago (2012-11-23 17:01:20 UTC) #1
ngeoffray
LGTM https://codereview.chromium.org/11421060/diff/1/dart/sdk/lib/_internal/compiler/implementation/compiler.dart File dart/sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/11421060/diff/1/dart/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode360 dart/sdk/lib/_internal/compiler/implementation/compiler.dart:360: unreported.measure(() => runCompiler(uri)); Will that just measure the ...
8 years ago (2012-11-27 09:14:07 UTC) #2
ahe
https://codereview.chromium.org/11421060/diff/1/dart/sdk/lib/_internal/compiler/implementation/compiler.dart File dart/sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/11421060/diff/1/dart/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode360 dart/sdk/lib/_internal/compiler/implementation/compiler.dart:360: unreported.measure(() => runCompiler(uri)); On 2012/11/27 09:14:07, ngeoffray wrote: > ...
8 years ago (2012-11-30 12:00:37 UTC) #3
ngeoffray
8 years ago (2012-11-30 12:05:28 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698