Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 11421057: Remove awful testing hack for testing extensions. (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)
Modified:
8 years ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove awful testing hack for testing extensions. There is absolutely no reason to make extension testing magical. We know exactly what to copy and can copy it to temporary directory instead of treating it as a multitest. R=whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -61 lines) Patch
M tests/standalone/io/test_extension_test.dart View 1 chunk +46 lines, -61 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 1 month ago (2012-11-23 10:14:26 UTC) #1
Bill Hesse
8 years, 1 month ago (2012-11-23 14:26:10 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698