Fix missing classes in native emitters superclass info.

Fix missing classes in native emitters superclass info.

Also tidied up the dispatch metadata generator.

Committed: https://code.google.com/p/dart/source/detail?r=15340

[karlklose, 2012-11-23 13:07:24]

https://codereview.chromium.org/11421049/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart
(right):

https://codereview.chromium.org/11421049/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart:334:
js.Expression existing = tagDefns[tag];
Why not type this js.VariableUse?

https://codereview.chromium.org/11421049/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart:342: if
(existing is js.VariableUse &&
Is the purpose of this is-check to make the editor not show a warning?

https://codereview.chromium.org/11421049/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart:347: //
Re-use the previously created temporary variable.
So this is dead code currently?

https://codereview.chromium.org/11421049/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/native_handler.dart (right):

https://codereview.chromium.org/11421049/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/native_handler.dart:299: final
Set<ClassElement> doneAddSubtypes = new Set<ClassElement>();
How about the name 'processedClasses'?

https://codereview.chromium.org/11421049/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/native_handler.dart:331:
addSubtypes(cls.superclass, emitter);
Why does this terminate?

[sra1, 2012-11-24 00:05:50]

https://codereview.chromium.org/11421049/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart
(right):

https://codereview.chromium.org/11421049/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart:334:
js.Expression existing = tagDefns[tag];
On 2012/11/23 13:07:24, karlklose wrote:
> Why not type this js.VariableUse?

Because it can be other things, e.g. a string expression (see comment line 320

https://codereview.chromium.org/11421049/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart:342: if
(existing is js.VariableUse &&
On 2012/11/23 13:07:24, karlklose wrote:
> Is the purpose of this is-check to make the editor not show a warning?

No, it is to check whether CSE has already happened.

https://codereview.chromium.org/11421049/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart:347: //
Re-use the previously created temporary variable.
On 2012/11/23 13:07:24, karlklose wrote:
> So this is dead code currently?

Yes, but we can use the dispatch for code sharing and I don't want to lose that
by having it overlooked.

https://codereview.chromium.org/11421049/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/native_handler.dart (right):

https://codereview.chromium.org/11421049/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/native_handler.dart:299: final
Set<ClassElement> doneAddSubtypes = new Set<ClassElement>();
On 2012/11/23 13:07:24, karlklose wrote:
> How about the name 'processedClasses'?

We already have three sets of classes to do with the method 'processClass',
which is a different thing to adding the subtypes.

https://codereview.chromium.org/11421049/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/native_handler.dart:331:
addSubtypes(cls.superclass, emitter);
On 2012/11/23 13:07:24, karlklose wrote:
> Why does this terminate?

The check on line 326 is a standard graph algorithm pattern for visiting each
node at most once.

[karlklose, 2012-11-26 11:24:56]

LGTM.

https://codereview.chromium.org/11421049/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/native_handler.dart (right):

https://codereview.chromium.org/11421049/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/native_handler.dart:331:
addSubtypes(cls.superclass, emitter);
Ah, I did not see l. 327.