Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 11420066: Fix bug 6713 (Closed)

Created:
8 years, 1 month ago by hausner
Modified:
8 years, 1 month ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug 6713 Ensure that we find the correct closure type class when re-parsing a nested function or closure. Committed: https://code.google.com/p/dart/source/detail?r=15113

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M runtime/vm/object.cc View 1 2 2 chunks +13 lines, -5 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
8 years, 1 month ago (2012-11-19 18:16:58 UTC) #1
regis
LGTM http://codereview.chromium.org/11420066/diff/3001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): http://codereview.chromium.org/11420066/diff/3001/runtime/vm/parser.cc#newcode5039 runtime/vm/parser.cc:5039: if (signature_class.IsNull()) { ASSERT(is_new_closure); or you could set ...
8 years, 1 month ago (2012-11-19 19:20:32 UTC) #2
hausner
8 years, 1 month ago (2012-11-19 21:35:04 UTC) #3
Thank you

http://codereview.chromium.org/11420066/diff/3001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/11420066/diff/3001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:5039: if (signature_class.IsNull()) {
On 2012/11/19 19:20:32, regis wrote:
> ASSERT(is_new_closure);
> or you could set the signature_class to function.signature_class() only if
> !is_new_closure:
> 
> Class& signature_class = Class::ZoneHandle();
> if (!is_new_closure) {
>   signature_class = function.signature_class();
> }

Done.

Powered by Google App Engine
This is Rietveld 408576698