Dartifying dart:html type names.

Dartifying dart:html type names.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=15739

[Emily Fortuna, 2012-12-04 01:57:19]

Wow, what a CL!
just a few suggestions, then lgtm.

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:1363: /// @domName CSSCharsetRule;
@docsEditable true
I'm assuming this is the same as the "deleted" lines on the other side?

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:18998: FileSystemSync
webkitRequestFileSystemSync(int type, int size) native;
DomFileSystemSync?

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/scripts/htmlrena...
File sdk/lib/html/scripts/htmlrenamer.py (right):

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/scripts/htmlrena...
sdk/lib/html/scripts/htmlrenamer.py:398: # Strip off any SVG prefix.
remove "SVG" from this line.

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/templates/html/d...
File sdk/lib/html/templates/html/dart2js/impl_WorkerContext.darttemplate
(right):

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/templates/html/d...
sdk/lib/html/templates/html/dart2js/impl_WorkerContext.darttemplate:7: ///
@domName $DOMNAME
+ "; @docsEditable true"

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/templates/html/d...
File sdk/lib/html/templates/html/dartium/indexed_db_dartium.darttemplate
(right):

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/templates/html/d...
sdk/lib/html/templates/html/dartium/indexed_db_dartium.darttemplate:16: class
_KeyRangeFactoryProvider {
Not to make this enormous CL any larger, but I thought you were trying to get
rid of the FactoryProviders?

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/templates/html/i...
File sdk/lib/html/templates/html/impl/impl_IDBKeyRange.darttemplate (right):

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/templates/html/i...
sdk/lib/html/templates/html/impl/impl_IDBKeyRange.darttemplate:5: part of html;
part of indexed_db?

[blois, 2012-12-04 17:35:36]

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:1363: /// @domName CSSCharsetRule;
@docsEditable true
On 2012/12/04 01:57:19, Emily Fortuna wrote:
> I'm assuming this is the same as the "deleted" lines on the other side?

Yep- alphabetizing changes. There should not be anything in this CL except for
renames.

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:18998: FileSystemSync
webkitRequestFileSystemSync(int type, int size) native;
On 2012/12/04 01:57:19, Emily Fortuna wrote:
> DomFileSystemSync?

We had another bug that we should remove the DOM prefix for the FileSystem and
ApplicationCache, so doing that at the same time (avoiding rename twice).

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/scripts/htmlrena...
File sdk/lib/html/scripts/htmlrenamer.py (right):

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/scripts/htmlrena...
sdk/lib/html/scripts/htmlrenamer.py:398: # Strip off any SVG prefix.
On 2012/12/04 01:57:19, Emily Fortuna wrote:
> remove "SVG" from this line.

Done.

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/templates/html/d...
File sdk/lib/html/templates/html/dart2js/impl_WorkerContext.darttemplate
(right):

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/templates/html/d...
sdk/lib/html/templates/html/dart2js/impl_WorkerContext.darttemplate:7: ///
@domName $DOMNAME
On 2012/12/04 01:57:19, Emily Fortuna wrote:
> + "; @docsEditable true"

@docsEditable "true" is only added to doc comments that come from our IDL
generation system, as that's where the doc replacement will happen.

All other docs should be edited directly in these files.

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/templates/html/d...
File sdk/lib/html/templates/html/dartium/indexed_db_dartium.darttemplate
(right):

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/templates/html/d...
sdk/lib/html/templates/html/dartium/indexed_db_dartium.darttemplate:16: class
_KeyRangeFactoryProvider {
On 2012/12/04 01:57:19, Emily Fortuna wrote:
> Not to make this enormous CL any larger, but I thought you were trying to get
> rid of the FactoryProviders?

I just moved them from elsewhere to here, but opened bug
http://code.google.com/p/dart/issues/detail?id=7129 to track.

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/templates/html/i...
File sdk/lib/html/templates/html/impl/impl_IDBKeyRange.darttemplate (right):

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/templates/html/i...
sdk/lib/html/templates/html/impl/impl_IDBKeyRange.darttemplate:5: part of html;
On 2012/12/04 01:57:19, Emily Fortuna wrote:
> part of indexed_db?

Done.

[Emily Fortuna, 2012-12-04 17:37:59]

lgtm

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/templates/html/d...
File sdk/lib/html/templates/html/dart2js/impl_WorkerContext.darttemplate
(right):

https://codereview.chromium.org/11419300/diff/1/sdk/lib/html/templates/html/d...
sdk/lib/html/templates/html/dart2js/impl_WorkerContext.darttemplate:7: ///
@domName $DOMNAME
On 2012/12/04 17:35:36, blois wrote:
> On 2012/12/04 01:57:19, Emily Fortuna wrote:
> > + "; @docsEditable true"
> 
> @docsEditable "true" is only added to doc comments that come from our IDL
> generation system, as that's where the doc replacement will happen.
> 
> All other docs should be edited directly in these files.

I haven't explored the exact mechanism for the dartdoc comments, but last week I
found that if you didn't have the tag "@docsEditable true" for a method, your
comments would just be ignored. :-/

[sra1, 2012-12-04 20:26:23]

lgtm

https://chromiumcodereview.appspot.com/11419300/diff/11013/sdk/lib/html/src/d...
File sdk/lib/html/src/dart2js_Conversions.dart (left):

https://chromiumcodereview.appspot.com/11419300/diff/11013/sdk/lib/html/src/d...
sdk/lib/html/src/dart2js_Conversions.dart:100: * Converts a native IDBKey into a
Dart object.
Move the comment at the top of the file too.