Issue 11419294: Use language or userlanguage (IE) depending on what's defined in the browser.

Issue 11419294: Use language or userlanguage (IE) depending on what's defined in the browser. (Closed)

Created:
8 years ago by Emily Fortuna

Modified:
8 years ago

Reviewers:
Alan Knight, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use language or userlanguage (IE) depending on what's defined in the browser. Fix for http://code.google.com/p/dart/issues/detail?id=6237 BUG=6237 Committed: https://code.google.com/p/dart/source/detail?r=15656

Patch Set 3 : remove parens from getter! #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -41 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 2	6 chunks	+5 lines, -35 lines	0 comments	Download
M	sdk/lib/html/scripts/systemhtml.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	sdk/lib/html/templates/html/dart2js/impl_Navigator.darttemplate	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
A +	tests/html/navigator_test.dart	View		2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://codereview.chromium.org/11419294/diff/1005/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (left): https://codereview.chromium.org/11419294/diff/1005/sdk/lib/html/dart2js/html_dart2js.dart#oldcode6021 sdk/lib/html/dart2js/html_dart2js.dart:6021: * Represents an HTML <div> element. This is due ...

8 years ago (2012-12-03 20:30:14 UTC) #1

blois

lgtm Just fix the getter syntax :) https://codereview.chromium.org/11419294/diff/1005/sdk/lib/html/templates/html/dart2js/impl_Navigator.darttemplate File sdk/lib/html/templates/html/dart2js/impl_Navigator.darttemplate (right): https://codereview.chromium.org/11419294/diff/1005/sdk/lib/html/templates/html/dart2js/impl_Navigator.darttemplate#newcode11 sdk/lib/html/templates/html/dart2js/impl_Navigator.darttemplate:11: String get ...

8 years ago (2012-12-03 20:42:05 UTC) #2

Emily Fortuna

8 years ago (2012-12-03 20:50:47 UTC) #3

https://codereview.chromium.org/11419294/diff/1005/sdk/lib/html/templates/htm...
File sdk/lib/html/templates/html/dart2js/impl_Navigator.darttemplate (right):

https://codereview.chromium.org/11419294/diff/1005/sdk/lib/html/templates/htm...
sdk/lib/html/templates/html/dart2js/impl_Navigator.darttemplate:11: String get
language() => JS('String', '#.language || #.userLanguage', this,
On 2012/12/03 20:42:05, blois wrote:
> no parens for getters!

oh man. why do I keep doing this!! 
thanks.

Expand Messages | Collapse Messages