Issue 11419245: Fix dartanalyzer issue with const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11419245: Fix dartanalyzer issue with const (Closed)

Created:
8 years ago by Emily Fortuna

Modified:
8 years ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix dartanalyzer issue with const BUG= Committed: https://code.google.com/p/dart/source/detail?r=15560

Patch Set 1 #

Patch Set 2 : generated files #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/src/KeyboardEventController.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

blois

8 years ago (2012-11-30 01:24:47 UTC) #2

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/11419245/diff/2001/sdk/lib/html/src/KeyboardE...
File sdk/lib/html/src/KeyboardEventController.dart (right):

https://codereview.chromium.org/11419245/diff/2001/sdk/lib/html/src/KeyboardE...
sdk/lib/html/src/KeyboardEventController.dart:38: int _ROMAN_ALPHABET_OFFSET =
"a".charCodes[0] - "A".charCodes[0];
final

Expand Messages | Collapse Messages