Issue 11419236: Fix relativeToPub() to work in the SDK too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11419236: Fix relativeToPub() to work in the SDK too. (Closed)

Created:
8 years ago by Bob Nystrom

Modified:
8 years ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix relativeToPub() to work in the SDK too. Committed: https://code.google.com/p/dart/source/detail?r=15545

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	utils/pub/io.dart	View		1 chunk	+7 lines, -6 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/11419236/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://codereview.chromium.org/11419236/diff/1/utils/pub/io.dart#newcode379 utils/pub/io.dart:379: while ((utilDir.filename != 'utils') && (utilDir.filename != 'util')) ...

8 years ago (2012-11-29 22:12:08 UTC) #2

Bob Nystrom

8 years ago (2012-12-04 21:38:24 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11419236/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/11419236/diff/1/utils/pub/io.dart#newcode379
utils/pub/io.dart:379: while ((utilDir.filename != 'utils') && (utilDir.filename
!= 'util')) {
On 2012/11/29 22:12:08, nweiz wrote:
> Unnecessary parentheses. Have faith in operator precedence!

Done. It is not my faith I question, but those of my so-called peers!

Expand Messages | Collapse Messages