Enforce rule in vm that factory name must match enclosing class name.

Enforce rule in vm that factory name must match enclosing class name.
This is a step towards removing support for obsolete default factory classes.
For now, disable tests using obsolete syntax. More will get disabled as support
is completely removed. We may then permanently remove some tests, while updating
and reenabling others whose purpose is not related to default factory classes.
Committed: https://code.google.com/p/dart/source/detail?r=15428

[hausner, 2012-11-28 00:26:38]

LGTM with question.

https://codereview.chromium.org/11419191/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/11419191/diff/1/runtime/vm/parser.cc#newcode2982
runtime/vm/parser.cc:2982: ParseQualIdent(&factory_name);
Does it still make sense to use ParseQualIdent now that the factory name must
match the class name? Essentially we can now at most have one period in the
name, and the first identifier we read must match the class name. What am I
missing?

https://codereview.chromium.org/11419191/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/11419191/diff/1/tests/language/language.statu...
tests/language/language.status:82: [ $compiler == none && $unchecked ]
Add a blank line before the new section?

https://codereview.chromium.org/11419191/diff/1/tests/language/language.statu...
tests/language/language.status:94: [ $compiler == none && $checked ]
Add a blank line before the new section?

[regis, 2012-11-28 01:09:18]

Thanks!

https://codereview.chromium.org/11419191/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/11419191/diff/1/runtime/vm/parser.cc#newcode2982
runtime/vm/parser.cc:2982: ParseQualIdent(&factory_name);
On 2012/11/28 00:26:38, hausner wrote:
> Does it still make sense to use ParseQualIdent now that the factory name must
> match the class name? Essentially we can now at most have one period in the
> name, and the first identifier we read must match the class name. What am I
> missing?

You are right. I simplified this code further.

https://codereview.chromium.org/11419191/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/11419191/diff/1/tests/language/language.statu...
tests/language/language.status:82: [ $compiler == none && $unchecked ]
On 2012/11/28 00:26:38, hausner wrote:
> Add a blank line before the new section?

I skipped the blank line to group these failures under "test issue 6324". But I
can repeat the comment with a blank line. Done.

https://codereview.chromium.org/11419191/diff/1/tests/language/language.statu...
tests/language/language.status:94: [ $compiler == none && $checked ]
On 2012/11/28 00:26:38, hausner wrote:
> Add a blank line before the new section?
ditto