Issue 11419138: Rename TlsSocket to SecureSocket, and all other Tls... items to Secure....

Issue 11419138: Rename TlsSocket to SecureSocket, and all other Tls... items to Secure.... (Closed)

Created:
8 years, 1 month ago by Bill Hesse

Modified:
8 years, 1 month ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename TlsSocket to SecureSocket, and all other Tls... items to Secure.... BUG= Committed: https://code.google.com/p/dart/source/detail?r=15274

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rename C++ class from Filter to SSLFilter. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+240 lines, -1753 lines)			Patch
M	runtime/bin/io_impl_sources.gypi	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/io_natives.cc	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	runtime/bin/io_sources.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	runtime/bin/secure_socket.h	View	1	4 chunks	+9 lines, -9 lines	0 comments	Download
A +	runtime/bin/secure_socket.cc	View	1	16 chunks	+45 lines, -45 lines	0 comments	Download
A	runtime/bin/secure_socket_patch.dart	View		1 chunk	+58 lines, -0 lines	0 comments	Download
D	runtime/bin/tls_socket.h	View		1 chunk	+0 lines, -106 lines	0 comments	Download
D	runtime/bin/tls_socket.cc	View		1 chunk	+0 lines, -484 lines	0 comments	Download
D	runtime/bin/tls_socket_patch.dart	View		1 chunk	+0 lines, -56 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/io_patch.dart	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	sdk/lib/io/io.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/io/iolib_sources.gypi	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	sdk/lib/io/secure_server_socket.dart	View		3 chunks	+9 lines, -9 lines	0 comments	Download
A +	sdk/lib/io/secure_socket.dart	View		22 chunks	+64 lines, -64 lines	0 comments	Download
D	sdk/lib/io/tls_server_socket.dart	View		1 chunk	+0 lines, -77 lines	0 comments	Download
D	sdk/lib/io/tls_socket.dart	View		1 chunk	+0 lines, -539 lines	0 comments	Download
A +	tests/standalone/io/secure_server_stream_test.dart	View		6 chunks	+10 lines, -10 lines	0 comments	Download
A +	tests/standalone/io/secure_server_test.dart	View		6 chunks	+10 lines, -10 lines	0 comments	Download
A +	tests/standalone/io/secure_socket_test.dart	View	1	1 chunk	+11 lines, -11 lines	0 comments	Download
A +	tests/standalone/io/secure_stream_test.dart	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
D	tests/standalone/io/tls_server_stream_test.dart	View		1 chunk	+0 lines, -98 lines	0 comments	Download
D	tests/standalone/io/tls_server_test.dart	View		1 chunk	+0 lines, -115 lines	0 comments	Download
D	tests/standalone/io/tls_socket_test.dart	View		1 chunk	+0 lines, -60 lines	0 comments	Download
D	tests/standalone/io/tls_stream_test.dart	View		1 chunk	+0 lines, -36 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

8 years, 1 month ago (2012-11-23 07:31:15 UTC) #2

LGTM

https://codereview.chromium.org/11419138/diff/1/runtime/bin/secure_socket.h
File runtime/bin/secure_socket.h (right):

https://codereview.chromium.org/11419138/diff/1/runtime/bin/secure_socket.h#n...
runtime/bin/secure_socket.h:53: class Filter {
It might make sense to give this C++ filter class a name that is a bit more
specific. NSSFilter?

https://codereview.chromium.org/11419138/diff/1/tests/standalone/io/secure_so...
File tests/standalone/io/secure_socket_test.dart (right):

https://codereview.chromium.org/11419138/diff/1/tests/standalone/io/secure_so...
tests/standalone/io/secure_socket_test.dart:32: // TODO(3593): Use a Dart HTTPS
server for this test using SECURE server sockets.
Long line and SECURE -> secure.

https://codereview.chromium.org/11419138/diff/1/tests/standalone/io/secure_st...
File tests/standalone/io/secure_stream_test.dart (right):

https://codereview.chromium.org/11419138/diff/1/tests/standalone/io/secure_st...
tests/standalone/io/secure_stream_test.dart:18: // TODO(3593): Use a Dart HTTPS
server for this test using SECURE server sockets.
Ditto.

Expand Messages | Collapse Messages