Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 11419119: Don't use 'new Function' for lazily initialized getter. (Closed)

Created:
8 years, 1 month ago by ngeoffray
Modified:
8 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't use 'new Function' for lazily initialized getter. Committed: https://code.google.com/p/dart/source/detail?r=15249

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 1 3 chunks +15 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
8 years, 1 month ago (2012-11-21 15:53:53 UTC) #1
floitsch
https://codereview.chromium.org/11419119/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (left): https://codereview.chromium.org/11419119/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#oldcode332 sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:332: var getter = new Function("{ return $isolate." + fieldName ...
8 years, 1 month ago (2012-11-21 16:58:13 UTC) #2
ngeoffray
Thanks Florian for the feedback. PTAL
8 years, 1 month ago (2012-11-22 11:19:28 UTC) #3
floitsch
8 years, 1 month ago (2012-11-22 11:51:25 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698