Issue 11419073: Remove loading of function object in static calls.

Issue 11419073: Remove loading of function object in static calls. (Closed)

Created:
8 years, 1 month ago by srdjan

Modified:
8 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove loading of function object in static calls. Committed: https://code.google.com/p/dart/source/detail?r=15126

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+150 lines, -148 lines)			Patch
M	runtime/vm/code_generator.cc	View	1	5 chunks	+29 lines, -22 lines	0 comments	Download
M	runtime/vm/code_patcher_arm.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/code_patcher_ia32.cc	View	1	2 chunks	+49 lines, -20 lines	0 comments	Download
M	runtime/vm/code_patcher_x64.cc	View	1	3 chunks	+48 lines, -18 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View		3 chunks	+12 lines, -43 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View		3 chunks	+12 lines, -40 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/11419073/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/11419073/diff/1/runtime/vm/code_generator.cc#newcode1554 runtime/vm/code_generator.cc:1554: } else { You could remove the else. ...

8 years, 1 month ago (2012-11-19 23:31:16 UTC) #2

srdjan

8 years, 1 month ago (2012-11-19 23:46:12 UTC) #3

https://codereview.chromium.org/11419073/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/11419073/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1554: } else {
On 2012/11/19 23:31:16, regis wrote:
> You could remove the else.

Done.

https://codereview.chromium.org/11419073/diff/1/runtime/vm/code_patcher_ia32.cc
File runtime/vm/code_patcher_ia32.cc (right):

https://codereview.chromium.org/11419073/diff/1/runtime/vm/code_patcher_ia32....
runtime/vm/code_patcher_ia32.cc:19: //  2: mov EDX, immediate 2
On 2012/11/19 23:31:16, regis wrote:
> Is this comment still valid in all call cases?

Fixed, marked as Dart instance call. Maybe I should merge the two in next CL.

https://codereview.chromium.org/11419073/diff/1/runtime/vm/code_patcher_x64.cc
File runtime/vm/code_patcher_x64.cc (right):

https://codereview.chromium.org/11419073/diff/1/runtime/vm/code_patcher_x64.c...
runtime/vm/code_patcher_x64.cc:19: //  10: 49 ba imm64  mov R10, immediate 2
On 2012/11/19 23:31:16, regis wrote:
> Comment still valid?

ditto

Expand Messages | Collapse Messages