Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 11419056: Forgot to change the condition to be true in a do/while loop that has phi updates: the condition ha… (Closed)

Created:
8 years, 1 month ago by ngeoffray
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Forgot to change the condition to be true in a do/while loop that has phi updates: the condition has already been evaluated. Committed: https://code.google.com/p/dart/source/detail?r=15059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/do_while3_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ngeoffray
8 years, 1 month ago (2012-11-18 14:53:17 UTC) #1
floitsch
8 years, 1 month ago (2012-11-18 22:02:21 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698