Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 11419037: Use the constant system to do a subtype type in the compile time constant handler. This is needed b… (Closed)

Created:
8 years, 1 month ago by ngeoffray
Modified:
8 years, 1 month ago
Reviewers:
karlklose, floitsch
CC:
reviews_dartlang.org, sra1
Visibility:
Public.

Description

Use the constant system to do a subtype type in the compile time constant handler. This is needed because of how we treat int and double specially. Committed: https://code.google.com/p/dart/source/detail?r=15014

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M sdk/lib/_internal/compiler/implementation/compile_time_constants.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/language/compile_time_constant_q_test.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ngeoffray
8 years, 1 month ago (2012-11-16 14:07:12 UTC) #1
floitsch
8 years, 1 month ago (2012-11-16 14:35:33 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698