Issue 11419008: Added O_CLOEXEC to the flags parameter of open() calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11419008: Added O_CLOEXEC to the flags parameter of open() calls (Closed)

Created:
8 years, 1 month ago by kustermann

Modified:
8 years, 1 month ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added O_CLOEXEC to the flags parameter of open() calls To prevent sub-processes from inheriting open file descriptors of the current process, the O_CLOEXEC flag is necessary. Committed: https://code.google.com/p/dart/source/detail?r=14963

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -3 lines)			Patch
M	runtime/bin/file_android.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/bin/file_linux.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/bin/file_macos.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!!!

Expand Messages | Collapse Messages