Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1444)

Issue 11419005: Cleanup the clobber tool (tools/clean_output_directory.py) (Closed)

Created:
8 years, 1 month ago by ricow1
Modified:
8 years, 1 month ago
Reviewers:
ahe, kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Cleanup the clobber tool (tools/clean_output_directory.py) Since everything is now placed inside the build directory we can simply nuke that - if you are cross compiling the output of that should be withing HOST_OUT/TARGET_OUT. Committed: https://code.google.com/p/dart/source/detail?r=14999

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -58 lines) Patch
M tools/clean_output_directory.py View 1 2 1 chunk +1 line, -58 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ricow1
8 years, 1 month ago (2012-11-15 12:03:42 UTC) #1
ricow1
This is dependent on: https://codereview.chromium.org/11411004/ and https://codereview.chromium.org/11412004/ (please note the nicely aligned numbers for those ...
8 years, 1 month ago (2012-11-15 12:06:20 UTC) #2
ricow1
On 2012/11/15 12:06:20, ricow1 wrote: > This is dependent on: > https://codereview.chromium.org/11411004/ > and > ...
8 years, 1 month ago (2012-11-15 12:34:23 UTC) #3
ahe
LGTM You could inline HOST_OS.
8 years, 1 month ago (2012-11-15 13:59:43 UTC) #4
ricow1
On 2012/11/15 13:59:43, ahe wrote: > LGTM > > You could inline HOST_OS. I thought ...
8 years, 1 month ago (2012-11-15 14:21:33 UTC) #5
ricow1
8 years, 1 month ago (2012-11-15 14:21:50 UTC) #6
On 2012/11/15 14:21:33, ricow1 wrote:
> On 2012/11/15 13:59:43, ahe wrote:
> > LGTM
> > 
> > You could inline HOST_OS.
> 
> I thought the clever python vm would do that for me :-)
and done

Powered by Google App Engine
This is Rietveld 408576698