Issue 11418267: Add authors and homepages to packages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11418267: Add authors and homepages to packages. (Closed)

Created:
8 years ago by dgrove

Modified:
8 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add authors and homepages to packages. Committed: https://code.google.com/p/dart/source/detail?r=15601

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -1 line)			Patch
M	pkg/args/pubspec.yaml	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/fixnum/pubspec.yaml	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/htmlescape/pubspec.yaml	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/http/pubspec.yaml	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/intl/pubspec.yaml	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/logging/pubspec.yaml	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/meta/pubspec.yaml	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/oauth2/pubspec.yaml	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	pkg/unittest/pubspec.yaml	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/webdriver/pubspec.yaml	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

8 years ago (2012-11-30 21:12:34 UTC) #2

One change, otherwise LGTM!

https://codereview.chromium.org/11418267/diff/1/pkg/oauth2/pubspec.yaml
File pkg/oauth2/pubspec.yaml (right):

https://codereview.chromium.org/11418267/diff/1/pkg/oauth2/pubspec.yaml#newcode4
pkg/oauth2/pubspec.yaml:4: description: A composable, Future-based API for
making HTTP requests.
Looks like Nathan copy/pasted the description from the HTTP package. Try:

A client library for authenticating with a remote service via OAuth2 on
behalf of a user, and making authorized HTTP requests with the user's OAuth2
credentials.

Expand Messages | Collapse Messages