Use the code point iterator in equality comparisons to C strings.

Use the code point iterator in equality comparisons to C strings.

Committed: https://code.google.com/p/dart/source/detail?r=15185

[cshapiro, 2012-11-20 19:05:24]

I restored the "str" argument name.  I cannot remember why I changed that to
utf8_array but this was quite confusing with the NUL checks.  Maybe cstr would
be the better name?

[siva, 2012-11-20 19:47:32]

https://codereview.chromium.org/11418095/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/11418095/diff/1/runtime/vm/object.cc#newcode1...
runtime/vm/object.cc:10038: bool String::Equals(const char* str) const {
yes cstr would be a better name.
Also please change the header file too.
(maybe the comment should state that the input is a c style
null terminated string with utf8 characters).

https://codereview.chromium.org/11418095/diff/1/runtime/vm/object.cc#newcode1...
runtime/vm/object.cc:10058: }
We should add a test case for this in order to ensure that
we regress it.

[cshapiro, 2012-11-20 23:41:12]

https://codereview.chromium.org/11418095/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/11418095/diff/1/runtime/vm/object.cc#newcode1...
runtime/vm/object.cc:10038: bool String::Equals(const char* str) const {
Done.

All of the C-strings in the dart VM are assumed to be UTF-8 encoded so there
should be no confusion about the encoding.

https://codereview.chromium.org/11418095/diff/1/runtime/vm/object.cc#newcode1...
runtime/vm/object.cc:10058: }
On 2012/11/20 19:47:32, siva wrote:
> We should add a test case for this in order to ensure that
> we regress it.

Done.

[siva, 2012-11-20 23:46:08]

lgtm