Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11418075: Dartifying members. (Closed)

Created:
8 years, 1 month ago by blois
Modified:
8 years ago
Reviewers:
Bob Nystrom, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Dartifying members. Updating dart:html to generate members which follow the Dart naming guidelines. BUG=4830 Committed: https://code.google.com/p/dart/source/detail?r=15405

Patch Set 1 #

Total comments: 4

Patch Set 2 : Adding deprecated innerHTML for transition. #

Patch Set 3 : Fixing up OpenGL ES member names. #

Patch Set 4 : Fixing menuelement.compact exclusion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+794 lines, -606 lines) Patch
M pkg/unittest/lib/html_config.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/unittest/lib/html_enhanced_config.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/unittest/lib/interactive_html_config.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M samples/calculator/tape.dart View 6 chunks +13 lines, -13 lines 0 comments Download
M samples/chat/js_client/code.js View 2 chunks +2 lines, -2 lines 0 comments Download
M samples/dartcombat/setup.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/dartcombat/views.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M samples/isolate_html/isolate_sample.dart View 5 chunks +7 lines, -7 lines 0 comments Download
M samples/playground/playground.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/playground/playground.html View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/SwarmViews.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M samples/third_party/dromaeo/Dromaeo.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M samples/third_party/dromaeo/tests/dom-modify.html View 24 chunks +42 lines, -42 lines 0 comments Download
M samples/third_party/dromaeo/tests/dom-modify-html.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M samples/third_party/dromaeo/tests/dom-modify-htmlidiomatic.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M samples/third_party/dromaeo/tests/dom-query.html View 22 chunks +40 lines, -40 lines 0 comments Download
M samples/third_party/dromaeo/tests/dom-query-html.dart View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M samples/third_party/dromaeo/tests/dom-query-htmlidiomatic.dart View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M samples/third_party/dromaeo/tests/dom-traverse.html View 22 chunks +40 lines, -40 lines 0 comments Download
M samples/third_party/dromaeo/tests/dom-traverse-html.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M samples/third_party/dromaeo/tests/dom-traverse-htmlidiomatic.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 3 53 chunks +120 lines, -53 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 56 chunks +156 lines, -56 lines 0 comments Download
M sdk/lib/html/scripts/htmlrenamer.py View 1 2 3 6 chunks +16 lines, -3 lines 0 comments Download
M sdk/lib/html/src/shared_FactoryProviders.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/html/src/shared_SVGFactoryProviders.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/templates/html/impl/impl_DocumentFragment.darttemplate View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Element.darttemplate View 1 2 3 4 chunks +14 lines, -6 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_SvgElement.darttemplate View 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 2 3 24 chunks +72 lines, -72 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 2 3 26 chunks +76 lines, -76 lines 0 comments Download
M tests/html/client_rect_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/cssstyledeclaration_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/datalistelement_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/documentfragment_test.dart View 4 chunks +23 lines, -23 lines 0 comments Download
M tests/html/element_add_test.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M tests/html/element_classes_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/html/event_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/form_element_test.dart View 2 chunks +11 lines, -11 lines 0 comments Download
M tests/html/html.status View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M tests/html/htmlcollection_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/htmlelement_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/html/js_interop_1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/js_interop_2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/js_interop_3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/postmessage_structured_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/svg_1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/svg_2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/svg_3_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/html/svgelement_test.dart View 3 chunks +9 lines, -9 lines 0 comments Download
M tests/html/url_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/window_open_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/xmldocument_test.dart View 6 chunks +25 lines, -25 lines 0 comments Download
M tests/html/xmlelement_test.dart View 9 chunks +38 lines, -38 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
8 years, 1 month ago (2012-11-20 00:11:30 UTC) #1
Bob Nystrom
I just skimmed but the names I saw looked great. Yay for consistency! https://codereview.chromium.org/11418075/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File ...
8 years, 1 month ago (2012-11-20 00:35:09 UTC) #2
blois
https://codereview.chromium.org/11418075/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11418075/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode5641 sdk/lib/html/dart2js/html_dart2js.dart:5641: CSSStyleSheet createCssStyleSheet(String title, String media) native "createCSSStyleSheet"; On 2012/11/20 ...
8 years, 1 month ago (2012-11-20 00:44:41 UTC) #3
sra1
8 years ago (2012-11-26 22:52:21 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698