First part of static call cleanup: store static call targets into code object, referenced by code-o…

First part of static call cleanup: store static call targets into code object, referenced by code-offset.
Committed: https://code.google.com/p/dart/source/detail?r=15091

[siva, 2012-11-16 23:15:23]

lgtm

https://codereview.chromium.org/11418046/diff/7001/runtime/vm/flow_graph_comp...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/11418046/diff/7001/runtime/vm/flow_graph_comp...
runtime/vm/flow_graph_compiler.cc:439: void
FlowGraphCompiler::FinalizeStaticCallTargetsTable(const Code& code) {
ASSERT(code.static_calls_target_table() == Array::null());

https://codereview.chromium.org/11418046/diff/7001/runtime/vm/flow_graph_comp...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://codereview.chromium.org/11418046/diff/7001/runtime/vm/flow_graph_comp...
runtime/vm/flow_graph_compiler_ia32.cc:1095: // TODO(srdjan): Remove load RCX
with function.
load ECX with function

https://codereview.chromium.org/11418046/diff/7001/runtime/vm/native_entry_te...
File runtime/vm/native_entry_test.cc (right):

https://codereview.chromium.org/11418046/diff/7001/runtime/vm/native_entry_te...
runtime/vm/native_entry_test.cc:65: uword target_address = 0;
TODO that you will replace GetStaticCallAt with
Code::GetStaticCallTaregtAtOffset(...)

One performance point here, it would be more optimal to
get the code object from the stack frame than by using
Code::LookupCode(pc) inside Code::GetStaticCallTargetAt(..).

You could write this code as:
const Code& code = Code::Handle(static_call_frame->LookupDartCode());
uword offset = (static_caller_frame->pc() - code.EntryPoint());
const Function& target_function_2 =
Function::Handle(code.GetStaticCallTargetAtOffset(offset));

https://codereview.chromium.org/11418046/diff/7001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/11418046/diff/7001/runtime/vm/object.h#newcod...
runtime/vm/object.h:2495: static RawFunction* GetStaticCallTargetAt(uword pc);
It might make sense to also have an instance method
RawFunction* GetStaticCallTargetAtOffset(uword offset);
for the cases when we can get the code object optimally
from the stack frame.

[srdjan, 2012-11-17 00:47:24]

Please have another look. Merged resolved static call table if static calls
target table.

https://codereview.chromium.org/11418046/diff/7001/runtime/vm/flow_graph_comp...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/11418046/diff/7001/runtime/vm/flow_graph_comp...
runtime/vm/flow_graph_compiler.cc:439: void
FlowGraphCompiler::FinalizeStaticCallTargetsTable(const Code& code) {
On 2012/11/16 23:15:23, siva wrote:
> ASSERT(code.static_calls_target_table() == Array::null());

Done.

https://codereview.chromium.org/11418046/diff/7001/runtime/vm/flow_graph_comp...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://codereview.chromium.org/11418046/diff/7001/runtime/vm/flow_graph_comp...
runtime/vm/flow_graph_compiler_ia32.cc:1095: // TODO(srdjan): Remove load RCX
with function.
On 2012/11/16 23:15:23, siva wrote:
> load ECX with function

Done.

https://codereview.chromium.org/11418046/diff/7001/runtime/vm/native_entry_te...
File runtime/vm/native_entry_test.cc (right):

https://codereview.chromium.org/11418046/diff/7001/runtime/vm/native_entry_te...
runtime/vm/native_entry_test.cc:65: uword target_address = 0;
On 2012/11/16 23:15:23, siva wrote:
> TODO that you will replace GetStaticCallAt with
> Code::GetStaticCallTaregtAtOffset(...)
> 
> One performance point here, it would be more optimal to
> get the code object from the stack frame than by using
> Code::LookupCode(pc) inside Code::GetStaticCallTargetAt(..).
> 
> You could write this code as:
> const Code& code = Code::Handle(static_call_frame->LookupDartCode());
> uword offset = (static_caller_frame->pc() - code.EntryPoint());
> const Function& target_function_2 =
> Function::Handle(code.GetStaticCallTargetAtOffset(offset));
> 

Addressed as discussed

https://codereview.chromium.org/11418046/diff/7001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/11418046/diff/7001/runtime/vm/object.h#newcod...
runtime/vm/object.h:2495: static RawFunction* GetStaticCallTargetAt(uword pc);
On 2012/11/16 23:15:23, siva wrote:
> It might make sense to also have an instance method
> RawFunction* GetStaticCallTargetAtOffset(uword offset);
> for the cases when we can get the code object optimally
> from the stack frame.
> 

Changed as discussed

[siva, 2012-11-17 01:23:37]

lgtm