Issue 11418010: Do not use StringBuffer to create strings from individual char

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11418010: Do not use StringBuffer to create strings from individual char (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)

Modified:
8 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Do not use StringBuffer to create strings from individual char codes in the HTTP parser. This was simple to do but we really should fix the performance of the string buffer for this case. R=sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14967

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -26 lines)			Patch
	M	sdk/lib/io/http_parser.dart	View		16 chunks	+26 lines, -26 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM!