Issue 11417051: Make List an abstract class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11417051: Make List an abstract class. (Closed)

Created:
8 years, 1 month ago by Anders Johnsen

Modified:
8 years, 1 month ago

Reviewers:
regis, floitsch, Mads Ager (google), ngeoffray

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, regis

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Make List an abstract class. This was the last interface in dart:core. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15240

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -61 lines)			Patch
M	runtime/lib/array_patch.dart	View		2 chunks	+1 line, -9 lines	0 comments	Download
M	runtime/tests/vm/dart/isolate_mirror_local_test.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3	2 chunks	+3 lines, -12 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/core_patch.dart	View	1 2 3	1 chunk	+1 line, -9 lines	0 comments	Download
M	sdk/lib/core/list.dart	View		3 chunks	+9 lines, -21 lines	0 comments	Download

Total messages: 4 (0 generated)

ngeoffray

Nice! Please note that this will break dart2js performance (dart2js checks against properties of the ...

8 years, 1 month ago (2012-11-18 14:32:14 UTC) #2

Not a reviewer, but LGTM anyway.