Issue 11417028: Include command in ProcessException.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11417028: Include command in ProcessException. (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)

Modified:
8 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Include command in ProcessException. R=sgjesse@google.com BUG=dartbug.com/4060 Committed: https://code.google.com/p/dart/source/detail?r=15010

Patch Set 2 : Address comment #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -4 lines)			Patch
	M	runtime/bin/process_patch.dart	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
	M	sdk/lib/io/process.dart	View	1	1 chunk	+19 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/11417028/diff/1/runtime/bin/process_patch.dart File runtime/bin/process_patch.dart (right): https://codereview.chromium.org/11417028/diff/1/runtime/bin/process_patch.dart#newcode162 runtime/bin/process_patch.dart:162: new ProcessException('$_path $arguments', We could also place path ...

8 years, 1 month ago (2012-11-16 12:45:02 UTC) #2

Mads Ager (google)

8 years, 1 month ago (2012-11-16 13:00:30 UTC) #3

https://codereview.chromium.org/11417028/diff/1/runtime/bin/process_patch.dart
File runtime/bin/process_patch.dart (right):

https://codereview.chromium.org/11417028/diff/1/runtime/bin/process_patch.dar...
runtime/bin/process_patch.dart:162: new ProcessException('$_path $arguments',
On 2012/11/16 12:45:02, Søren Gjesse wrote:
> We could also place path and arguments on the Process Exception. Then have the
> formatting there in toString and make path and arguments available on the
> exception.

Done.

Expand Messages | Collapse Messages

Issue 11417028: Include command in ProcessException. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment #

Messages