Do not canonicalize Type instances.

Do not canonicalize Type instances.

Committed: https://code.google.com/p/dart/source/detail?r=15000

[ngeoffray, 2012-11-15 12:28:12]

Code looks good, but what motivated this change?

[karlklose, 2012-11-15 12:49:01]

We don't need to canonicalize the results from runtimeType. By removing the
cache and using == instead of identical, we avoid caching an unlimited amount of
Type instances.

[ngeoffray, 2012-11-15 12:50:24]

On 2012/11/15 12:49:01, karlklose wrote:
> We don't need to canonicalize the results from runtimeType. By removing the
> cache and using == instead of identical, we avoid caching an unlimited amount
of
> Type instances.

Sounds good. LGTM!

[sra1, 2012-11-16 08:43:45]

lgtm

https://codereview.chromium.org/11417005/diff/1/tests/language/first_class_ty...
File tests/language/first_class_types_literals_test.dart (right):

https://codereview.chromium.org/11417005/diff/1/tests/language/first_class_ty...
tests/language/first_class_types_literals_test.dart:17: Expect.equals(int, int);
Since class literals are compile-time constants, I would still expect identity
here.

[sra1, 2012-11-16 08:43:46]

lgtm

lgtm

[sra1, 2012-11-16 08:43:49]

lgtm

lgtm

[karlklose, 2012-11-16 13:42:43]

https://codereview.chromium.org/11417005/diff/1/tests/language/first_class_ty...
File tests/language/first_class_types_literals_test.dart (right):

https://codereview.chromium.org/11417005/diff/1/tests/language/first_class_ty...
tests/language/first_class_types_literals_test.dart:17: Expect.equals(int, int);
They are not yet constants. I have a CL to make literals compile-time constants
and that CL contains tests for this.