Issue 11416352: Handle OAuth2 AuthorizationExceptions in pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11416352: Handle OAuth2 AuthorizationExceptions in pub. (Closed)

Created:
8 years ago by nweiz

Modified:
8 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle OAuth2 AuthorizationExceptions in pub. BUG=6950 Committed: https://code.google.com/p/dart/source/detail?r=15747

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -25 lines)			Patch
M	utils/pub/command_lish.dart	View	2 chunks	+13 lines, -17 lines	0 comments	Download
M	utils/pub/io.dart	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	utils/pub/oauth2.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	utils/tests/pub/pub_lish_test.dart	View	1 chunk	+23 lines, -2 lines	2 comments	Download
M	utils/tests/pub/test_pub.dart	View	2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One suggestion. LGTM. https://codereview.chromium.org/11416352/diff/1/utils/tests/pub/pub_lish_test.dart File utils/tests/pub/pub_lish_test.dart (right): https://codereview.chromium.org/11416352/diff/1/utils/tests/pub/pub_lish_test.dart#newcode90 utils/tests/pub/pub_lish_test.dart:90: expectLater(pub.nextErrLine(), equals('OAuth2 authorization failed (your ' ...

8 years ago (2012-12-05 17:39:46 UTC) #2

nweiz

8 years ago (2012-12-05 19:33:55 UTC) #3

https://codereview.chromium.org/11416352/diff/1/utils/tests/pub/pub_lish_test...
File utils/tests/pub/pub_lish_test.dart (right):

https://codereview.chromium.org/11416352/diff/1/utils/tests/pub/pub_lish_test...
utils/tests/pub/pub_lish_test.dart:90: expectLater(pub.nextErrLine(),
equals('OAuth2 authorization failed (your '
On 2012/12/05 17:39:46, Bob Nystrom wrote:
> The regular expect() function allows a literal in place of a matcher and
infers
> the equals(), so you can do:
> 
> expect(foo, 123);
> 
> Maybe support that in expectLater too?

That is supported. The "matcher" argument is passed directly to expect(). The
style I've seen people use involves explicitly calling "equals()", though.

Expand Messages | Collapse Messages