Refactored Android samples / embedder.

Refactored Android samples / embedder.

- Started moving generic embedder code from sample into runtime/embedders/android.  I'd like to move more in a later CL.
- Removed dependence on vm/bin in sample.

Ivan or Siva: can one of you review the changes under runtime?

Committed: https://code.google.com/p/dart/source/detail?r=15766

[vsm, 2012-12-04 21:26:01]

https://chromiumcodereview.appspot.com/11416343/diff/5001/runtime/embedders/a...
File runtime/embedders/android/android_embedder.gypi (right):

https://chromiumcodereview.appspot.com/11416343/diff/5001/runtime/embedders/a...
runtime/embedders/android/android_embedder.gypi:15: 'libdart_lib_withcore',
Note: this is almost libdart_export, except with this library instead of
libdart_lib.

[gram, 2012-12-04 22:03:42]

https://chromiumcodereview.appspot.com/11416343/diff/5001/runtime/vm/os_andro...
File runtime/vm/os_android.cc (right):

https://chromiumcodereview.appspot.com/11416343/diff/5001/runtime/vm/os_andro...
runtime/vm/os_android.cc:157: __android_log_vprint(ANDROID_LOG_INFO, "DartVM",
format, args);
Cool! If this is working we should probably remove the log() function I added in
android_extension.

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
File samples/android_sample/jni/android_extension.cc (right):

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
samples/android_sample/jni/android_extension.cc:15: #include
"jni/android_extension.h"
Thsi should come first:
http://www.corp.google.com/eng/doc/cppguide.xml#Names_and_Order_of_Includes

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
File samples/android_sample/jni/dart_host.cc (right):

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
samples/android_sample/jni/dart_host.cc:8: #include "jni/dart_host.h"
This should come first:
http://www.corp.google.com/eng/doc/cppguide.xml#Names_and_Order_of_Includes

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
File samples/android_sample/jni/graphics.cc (right):

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
samples/android_sample/jni/graphics.cc:8: #include "jni/graphics.h"
According to the Google C++ style guide, the header file associated with the .cc
file should come first before any other includes:

http://www.corp.google.com/eng/doc/cppguide.xml#Names_and_Order_of_Includes

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
File samples/android_sample/jni/timer.h (right):

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
samples/android_sample/jni/timer.h:23: #endif
Oddly, I was getting lint errors in Rietveld from not having terminal newlines,
and so I made sure to add them; now you are removing them lint doesn't seem to
be complaining. Weird.

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
File samples/android_sample/jni/vm_glue.cc (right):

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
samples/android_sample/jni/vm_glue.cc:62: if (strcmp(url,
"android_extension.dart") == 0) {
Can you add a TODO here that this should not be hardcoded but should be driven
from an import in the Dart script? We may eventually have several extensions
(3D, 2D, Box2D, etc) and the user may want to load only a subset of these for
use in their Android app.

[vsm, 2012-12-04 23:03:08]

Thanks, PTAL.

https://chromiumcodereview.appspot.com/11416343/diff/5001/runtime/vm/os_andro...
File runtime/vm/os_android.cc (right):

https://chromiumcodereview.appspot.com/11416343/diff/5001/runtime/vm/os_andro...
runtime/vm/os_android.cc:157: __android_log_vprint(ANDROID_LOG_INFO, "DartVM",
format, args);
Dart print() doesn't work yet, so I'll keep log until we get that working - I
assume you mean the log exported to Dart as a native function.

On 2012/12/04 22:03:42, gram wrote:
> Cool! If this is working we should probably remove the log() function I added
in
> android_extension.

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
File samples/android_sample/jni/android_extension.cc (right):

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
samples/android_sample/jni/android_extension.cc:15: #include
"jni/android_extension.h"
On 2012/12/04 22:03:42, gram wrote:
> Thsi should come first:
> http://www.corp.google.com/eng/doc/cppguide.xml#Names_and_Order_of_Includes

Done.

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
File samples/android_sample/jni/dart_host.cc (right):

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
samples/android_sample/jni/dart_host.cc:8: #include "jni/dart_host.h"
On 2012/12/04 22:03:42, gram wrote:
> This should come first:
> http://www.corp.google.com/eng/doc/cppguide.xml#Names_and_Order_of_Includes

Done.

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
File samples/android_sample/jni/graphics.cc (right):

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
samples/android_sample/jni/graphics.cc:8: #include "jni/graphics.h"
On 2012/12/04 22:03:42, gram wrote:
> According to the Google C++ style guide, the header file associated with the
.cc
> file should come first before any other includes:
> 
> http://www.corp.google.com/eng/doc/cppguide.xml#Names_and_Order_of_Includes

Done.

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
File samples/android_sample/jni/timer.h (right):

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
samples/android_sample/jni/timer.h:23: #endif
Strange.

On 2012/12/04 22:03:42, gram wrote:
> Oddly, I was getting lint errors in Rietveld from not having terminal
newlines,
> and so I made sure to add them; now you are removing them lint doesn't seem to
> be complaining. Weird.

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
File samples/android_sample/jni/vm_glue.cc (right):

https://chromiumcodereview.appspot.com/11416343/diff/5001/samples/android_sam...
samples/android_sample/jni/vm_glue.cc:62: if (strcmp(url,
"android_extension.dart") == 0) {
TODO added.  We'll need a table somewhere to associate a library with it's
native resolver (ResolveName below).

On 2012/12/04 22:03:42, gram wrote:
> Can you add a TODO here that this should not be hardcoded but should be driven
> from an import in the Dart script? We may eventually have several extensions
> (3D, 2D, Box2D, etc) and the user may want to load only a subset of these for
> use in their Android app.

[gram, 2012-12-04 23:20:31]

lgtm.

https://chromiumcodereview.appspot.com/11416343/diff/5001/runtime/vm/os_andro...
File runtime/vm/os_android.cc (right):

https://chromiumcodereview.appspot.com/11416343/diff/5001/runtime/vm/os_andro...
runtime/vm/os_android.cc:157: __android_log_vprint(ANDROID_LOG_INFO, "DartVM",
format, args);
Bummer, I thought this might be print()

On 2012/12/04 23:03:08, vsm wrote:
> Dart print() doesn't work yet, so I'll keep log until we get that working - I
> assume you mean the log exported to Dart as a native function.
> 
> On 2012/12/04 22:03:42, gram wrote:
> > Cool! If this is working we should probably remove the log() function I
added
> in
> > android_extension.
>

[siva, 2012-12-05 19:48:31]

lgtm