Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 11416340: Improve and fix constant propagation for type arguments. (Closed)

Created:
8 years ago by Florian Schneider
Modified:
8 years ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Improve and fix constant propagation for type arguments. Corretly match the constant propagator's analysis code for InstantiateTypeArguments with the code generator template for it and handle the case of NULL-type arguments. This improves code like new List() in checked mode. The old code would only improve code with type arguments like new List<type>(); Committed: https://code.google.com/p/dart/source/detail?r=15695

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 2 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Schneider
8 years ago (2012-12-04 13:19:57 UTC) #1
srdjan
8 years ago (2012-12-04 15:51:52 UTC) #2
LGTM and thanks

Powered by Google App Engine
This is Rietveld 408576698