Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 11416298: Rollback removing Skip for DartC (Closed)

Created:
8 years ago by scheglov
Modified:
8 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rollback removing Skip for DartC TBR For some reason this causes dart2js failures, but should not in theory. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M pkg/pkg.status View 2 chunks +2 lines, -2 lines 0 comments Download
M samples/tests/samples/samples.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
8 years ago (2012-11-30 22:36:37 UTC) #1
Brian Wilkerson
LGTM. Peter might understand why is caused a failure.
8 years ago (2012-11-30 22:42:50 UTC) #2
scheglov
8 years ago (2012-11-30 22:47:49 UTC) #3
Message was sent while issue was closed.
Issue was opened to track this problem.
http://code.google.com/p/dart/issues/detail?id=7071

Powered by Google App Engine
This is Rietveld 408576698