Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 11416294: Changing template file names to key off of the DOM name rather than Dart name. (Closed)

Created:
8 years ago by blois
Modified:
8 years ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Changing template file names to key off of the DOM name rather than Dart name. This avoids name conflicts when the templates are used for different libraries. Should probably also move templates into separate library folders, but we should also be consistent about keying off of DOM names. SVG changes are from a conflict on the Point type. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-8 lines, -482 lines) Patch
M sdk/lib/html/scripts/systemhtml.py View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/scripts/systemnative.py View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/html/templates/html/dart2js/impl_HTMLSelectElement.darttemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sdk/lib/html/templates/html/dart2js/impl_HTMLTableElement.darttemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
D sdk/lib/html/templates/html/dart2js/impl_LocalWindow.darttemplate View 1 chunk +0 lines, -151 lines 0 comments Download
D sdk/lib/html/templates/html/dart2js/impl_SelectElement.darttemplate View 1 chunk +0 lines, -25 lines 0 comments Download
D sdk/lib/html/templates/html/dart2js/impl_TableElement.darttemplate View 1 chunk +0 lines, -22 lines 0 comments Download
A + sdk/lib/html/templates/html/dart2js/impl_URL.darttemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
D sdk/lib/html/templates/html/dart2js/impl_Url.darttemplate View 1 chunk +0 lines, -19 lines 0 comments Download
A + sdk/lib/html/templates/html/dart2js/impl_Window.darttemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
D sdk/lib/html/templates/html/dartium/impl_LocalWindow.darttemplate View 1 chunk +0 lines, -39 lines 0 comments Download
sdk/lib/html/templates/html/dartium/impl_Window.darttemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
D sdk/lib/html/templates/html/impl/impl_CanvasElement.darttemplate View 1 chunk +0 lines, -15 lines 0 comments Download
A + sdk/lib/html/templates/html/impl/impl_HTMLCanvasElement.darttemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sdk/lib/html/templates/html/impl/impl_HTMLDocument.darttemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
D sdk/lib/html/templates/html/impl/impl_HtmlDocument.darttemplate View 1 chunk +0 lines, -83 lines 0 comments Download
D sdk/lib/html/templates/html/impl/impl_HttpRequest.darttemplate View 1 chunk +0 lines, -18 lines 0 comments Download
D sdk/lib/html/templates/html/impl/impl_Point.darttemplate View 1 chunk +0 lines, -13 lines 0 comments Download
A + sdk/lib/html/templates/html/impl/impl_SVGElement.darttemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sdk/lib/html/templates/html/impl/impl_SVGSVGElement.darttemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
D sdk/lib/html/templates/html/impl/impl_SvgElement.darttemplate View 1 chunk +0 lines, -88 lines 0 comments Download
D sdk/lib/html/templates/html/impl/impl_SvgSvgElement.darttemplate View 1 chunk +0 lines, -12 lines 0 comments Download
A + sdk/lib/html/templates/html/impl/impl_WebKitPoint.darttemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sdk/lib/html/templates/html/impl/impl_XMLHttpRequest.darttemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 2 chunks +1 line, -5 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
8 years ago (2012-11-30 21:40:30 UTC) #1
sra1
8 years ago (2012-11-30 21:45:09 UTC) #2
lgtm!

Powered by Google App Engine
This is Rietveld 408576698