Issue 11416280: Decouple the constant handler from the compiler so we can have more than one.

Issue 11416280: Decouple the constant handler from the compiler so we can have more than one. (Closed)

Created:
8 years ago by kasperl

Modified:
8 years ago

Reviewers:
ahe, ngeoffray, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Decouple the constant handler from the compiler so we can have more than one. Use a separate constant handler for metadata. R=sra@google.com,ngeoffray@google.com BUG=http://dartbug.com/7048 Committed: https://code.google.com/p/dart/source/detail?r=15582

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments. #

Patch Set 3 : Merge from master.' #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -56 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compile_time_constants.dart	View	1	16 chunks	+28 lines, -26 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 2	3 chunks	+2 lines, -21 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	6 chunks	+25 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/11416280/diff/1/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart (right): https://codereview.chromium.org/11416280/diff/1/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart#newcode589 sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:589: Constant compileConstant = handler.compileConstant; ? I think this ...

8 years ago (2012-11-30 12:16:35 UTC) #2

kasperl

https://codereview.chromium.org/11416280/diff/1/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart (right): https://codereview.chromium.org/11416280/diff/1/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart#newcode589 sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:589: Constant compileConstant = handler.compileConstant; On 2012/11/30 12:16:35, ngeoffray wrote: ...

8 years ago (2012-11-30 12:17:59 UTC) #3

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages