Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 11416197: Support Windows share paths in the Path class. (Closed)

Created:
8 years ago by Mads Ager (google)
Modified:
8 years ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support Windows share paths in the Path class. Use that to implement Directory.create(recursive: true) in a way that works with shares. The Path implementation has an additional piece of state. The actual path is treated like an absolute path except for toNativePath which adds back the extra backslash. The additional state is preserved in operations that produce new paths. R=sgjesse@google.com BUG=dartbug.com/6904 Committed: https://code.google.com/p/dart/source/detail?r=15385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -37 lines) Patch
M sdk/lib/io/directory_impl.dart View 2 chunks +51 lines, -17 lines 0 comments Download
M sdk/lib/io/path.dart View 2 chunks +22 lines, -1 line 0 comments Download
M sdk/lib/io/path_impl.dart View 8 chunks +35 lines, -19 lines 0 comments Download
M tests/standalone/io/path_test.dart View 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years ago (2012-11-27 10:25:04 UTC) #1
Søren Gjesse
8 years ago (2012-11-27 11:50:31 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698