Issue 11416136: Only require SSE2 at minimum hardware requirement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11416136: Only require SSE2 at minimum hardware requirement. (Closed)

Created:
8 years, 1 month ago by Florian Schneider

Modified:
8 years, 1 month ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Only require SSE2 at minimum hardware requirement. BUG=dart:6010 Committed: https://code.google.com/p/dart/source/detail?r=15253

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -21 lines)			Patch
M	runtime/vm/assembler_ia32.h	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View	1 2	2 chunks	+5 lines, -4 lines	0 comments	Download
M	runtime/vm/assembler_x64.h	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 2	2 chunks	+0 lines, -8 lines	0 comments	Download
M	runtime/vm/dart.cc	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Vyacheslav Egorov (Google)

8 years, 1 month ago (2012-11-22 11:12:18 UTC) #2

LGTM

I suggest killing sse3 detection to avoid confusion.