Implement input and output streams for secure network sockets.

Implement input and output streams for secure network sockets.


BUG=dart:6701
Committed: https://code.google.com/p/dart/source/detail?r=15267

[Bill Hesse, 2012-11-20 18:42:55]

https://codereview.chromium.org/11416108/diff/1005/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/11416108/diff/1005/runtime/bin/socket_patch.d...
runtime/bin/socket_patch.dart:468: if (_seenFirstOutEvent) {
See if statement below.

https://codereview.chromium.org/11416108/diff/3001/sdk/lib/io/tls_socket.dart
File sdk/lib/io/tls_socket.dart (right):

https://codereview.chromium.org/11416108/diff/3001/sdk/lib/io/tls_socket.dart...
sdk/lib/io/tls_socket.dart:315: // True if the underlying socket is closed, the
filter has been emptied of
Should we use doc comments for private methods?

[Søren Gjesse, 2012-11-20 21:13:07]

LGTM

I think you should make a follow-up CL where all the TLS socket tests is run
with both short reads and writes.

https://codereview.chromium.org/11416108/diff/3001/sdk/lib/io/tls_socket.dart
File sdk/lib/io/tls_socket.dart (right):

https://codereview.chromium.org/11416108/diff/3001/sdk/lib/io/tls_socket.dart...
sdk/lib/io/tls_socket.dart:315: // True if the underlying socket is closed, the
filter has been emptied of
On 2012/11/20 18:42:55, Bill Hesse wrote:
> Should we use doc comments for private methods?

Normally we don't.

https://codereview.chromium.org/11416108/diff/3001/tests/standalone/io/tls_se...
File tests/standalone/io/tls_server_stream_test.dart (right):

https://codereview.chromium.org/11416108/diff/3001/tests/standalone/io/tls_se...
tests/standalone/io/tls_server_stream_test.dart:15: var received = new
String.fromCharCodes(input.read());
The read is guaranteed to receive all the expected data.

https://codereview.chromium.org/11416108/diff/3001/tests/standalone/io/tls_se...
tests/standalone/io/tls_server_stream_test.dart:52: reply = reply.concat(new
String.fromCharCodes(socket.inputStream.read()));
Ditto.

[Mads Ager (google), 2012-11-21 06:59:53]

lgtm

https://codereview.chromium.org/11416108/diff/3001/tests/standalone/io/tls_se...
File tests/standalone/io/tls_server_stream_test.dart (right):

https://codereview.chromium.org/11416108/diff/3001/tests/standalone/io/tls_se...
tests/standalone/io/tls_server_stream_test.dart:15: var received = new
String.fromCharCodes(input.read());
On 2012/11/20 21:13:07, Søren Gjesse wrote:
> The read is guaranteed to receive all the expected data. 

is *not* guaranteed. :-)