Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 11416034: Fix some type annotations. (Closed)

Created:
8 years, 1 month ago by karlklose
Modified:
8 years, 1 month ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix some type annotations. Committed: https://code.google.com/p/dart/source/detail?r=15139

Patch Set 1 #

Patch Set 2 : Restore call to parseNode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 1 6 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
8 years, 1 month ago (2012-11-16 13:40:06 UTC) #1
sra1
lgtm Looks harmless enough. What was the bug?
8 years, 1 month ago (2012-11-16 19:04:00 UTC) #2
karlklose
8 years, 1 month ago (2012-11-19 13:13:58 UTC) #3
I thought calling MetadataAnnotation.parseNode(...) is unsafe, but perhaps you
can actually be sure that you only get PartialMetadataAnnotations.

Powered by Google App Engine
This is Rietveld 408576698