Added top level definition to Window.

Added top level definition to Window.

Committed: https://code.google.com/p/dart/source/detail?r=15022

[Andrei Mouravski, 2012-11-16 01:44:18]

16 lines of joy.

[blois, 2012-11-16 01:49:15]

lgtm

Code changes look fine.

[Kathy Walrath, 2012-11-16 16:47:06]

A few quibbles.

Does this really need to be in 3 files? That seems broken.

-k-

https://codereview.chromium.org/11416028/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11416028/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:22011: * Represents the top level context
object for web scripting.
I've been saying that classes should be noun phrases (not verb phrases). Only
methods and functions should be verbs.

So "Represents the" -> "The".

Or, if that's not correct, something like:

An object representing the top-level context for web scripting.

(top-level should be hyphenated since it comes before the noun)

https://codereview.chromium.org/11416028/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:22018: * **Note:** that this class
represents any window, whereas [LocalWindow] is
that this
-> This

[Andrei Mouravski, 2012-11-16 18:02:16]

Thanks for the review. Submitting.

P.S. Yes, this needs to be in three files. The go.sh generates the big library
files that are actually used, and we need those to snapshot the updates to
anywhere in the pipeline (IDL or src changes.)

https://codereview.chromium.org/11416028/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11416028/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:22011: * Represents the top level context
object for web scripting.
On 2012/11/16 16:47:06, Kathy Walrath wrote:
> I've been saying that classes should be noun phrases (not verb phrases). Only
> methods and functions should be verbs.
> 
> So "Represents the" -> "The".
> 
> Or, if that's not correct, something like:
> 
> An object representing the top-level context for web scripting.
> 
> (top-level should be hyphenated since it comes before the noun)

Done.

https://codereview.chromium.org/11416028/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:22018: * **Note:** that this class
represents any window, whereas [LocalWindow] is
On 2012/11/16 16:47:06, Kathy Walrath wrote:
> that this
> -> This

Done.