Issue 11416023: Removed DivElement align property as it is obsolete.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11416023: Removed DivElement align property as it is obsolete. (Closed)

Created:
8 years, 1 month ago by Andrei Mouravski

Modified:
8 years, 1 month ago

Reviewers:
vsm, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Removed DivElement align property as it is obsolete. Committed: https://code.google.com/p/dart/source/detail?r=14986

Patch Set 2 : Regenerated. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -28 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		14 chunks	+15 lines, -25 lines	0 comments	Download
M	sdk/lib/html/scripts/htmlrenamer.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

blois

https://codereview.chromium.org/11416023/diff/1/sdk/lib/html/scripts/htmlrenamer.py File sdk/lib/html/scripts/htmlrenamer.py (right): https://codereview.chromium.org/11416023/diff/1/sdk/lib/html/scripts/htmlrenamer.py#newcode124 sdk/lib/html/scripts/htmlrenamer.py:124: "DivElement.align", Need to regen html_dart2js and html_dartium.

8 years, 1 month ago (2012-11-15 22:52:50 UTC) #2

Andrei Mouravski

html_dartium is wacky because it was not re-upped at last change.

8 years, 1 month ago (2012-11-15 23:02:13 UTC) #3

vsm

LGTM - sorry about the old code that snuck in from my last CL.

8 years, 1 month ago (2012-11-15 23:07:30 UTC) #4

lgtm

Expand Messages | Collapse Messages

Issue 11416023: Removed DivElement align property as it is obsolete. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Regenerated. #

Messages