Issue 11416004: Reject deprecated language features.

Issue 11416004: Reject deprecated language features. (Closed)

Created:
8 years, 1 month ago by ahe

Modified:
8 years, 1 month ago

Reviewers:
Johnni Winther, karlklose, ngeoffray

CC:
reviews_dartlang.org, Johnni Winther

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Reject deprecated language features. Or rather, provide the following options which do: --reject-deprecated-language-features Reject deprecated language features. Without this option, the compiler will accept language features that are no longer valid according to The Dart Programming Language Specification, version 0.12, M1. --report-sdk-use-of-deprecated-language-features Report use of deprecated features in Dart platform libraries. Without this option, the compiler will silently accept use of deprecated language features from these libraries. The option --reject-deprecated-language-features controls if these usages are reported as errors or warnings. Committed: https://code.google.com/p/dart/source/detail?r=15007

Patch Set 1 : #

Total comments: 8

Patch Set 2 : Address review comments #

Patch Set 3 : Rebased #

Patch Set 4 : Fix test issues #

Total comments: 2

Patch Set 5 : abstract class in resolver test #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -47 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 2 3	6 chunks	+24 lines, -8 lines	2 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/dart2js.dart	View	1 2	2 chunks	+20 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View	1 2	1 chunk	+7 lines, -7 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/native_handler.dart	View	1 2 3	1 chunk	+9 lines, -6 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2	2 chunks	+16 lines, -10 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart	View	1	6 chunks	+11 lines, -5 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/util/util.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/warnings.dart	View		1 chunk	+13 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js/compiler_helper.dart	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	dart/tests/compiler/dart2js/mock_compiler.dart	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js/resolver_test.dart	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js/type_checker_test.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js/value_range_test.dart	View	1 2 3	1 chunk	+23 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM if you change the option name. https://codereview.chromium.org/11416004/diff/1009/dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart File dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart (right): https://codereview.chromium.org/11416004/diff/1009/dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart#newcode38 dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart:38: omgThisIsALongOptionName: omg, ...

8 years, 1 month ago (2012-11-15 10:17:26 UTC) #2

ngeoffray

LGTM https://codereview.chromium.org/11416004/diff/1009/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart File dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/11416004/diff/1009/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode2919 dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart:2919: if (compiler.rejectDeprecatedFeatures && Why are you special casing ...

8 years, 1 month ago (2012-11-15 10:34:02 UTC) #3

ahe

Hi Karl and Nicolas, Thank you for taking a look. Cheers, Peter https://codereview.chromium.org/11416004/diff/1009/dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart File dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart ...

8 years, 1 month ago (2012-11-16 07:07:36 UTC) #4

ngeoffray

Still LGTM https://codereview.chromium.org/11416004/diff/4002/dart/tests/compiler/dart2js/resolver_test.dart File dart/tests/compiler/dart2js/resolver_test.dart (left): https://codereview.chromium.org/11416004/diff/4002/dart/tests/compiler/dart2js/resolver_test.dart#oldcode607 dart/tests/compiler/dart2js/resolver_test.dart:607: compiler.parseScript("""interface A extends B {} As discussed, ...

8 years, 1 month ago (2012-11-16 11:31:18 UTC) #6

ahe

Thank you. https://codereview.chromium.org/11416004/diff/4002/dart/tests/compiler/dart2js/resolver_test.dart File dart/tests/compiler/dart2js/resolver_test.dart (left): https://codereview.chromium.org/11416004/diff/4002/dart/tests/compiler/dart2js/resolver_test.dart#oldcode607 dart/tests/compiler/dart2js/resolver_test.dart:607: compiler.parseScript("""interface A extends B {} On 2012/11/16 ...

8 years, 1 month ago (2012-11-16 11:35:20 UTC) #7

Johnni Winther

lgtm https://codereview.chromium.org/11416004/diff/12016/dart/sdk/lib/_internal/compiler/implementation/compiler.dart File dart/sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/11416004/diff/12016/dart/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode782 dart/sdk/lib/_internal/compiler/implementation/compiler.dart:782: : MessageKind.DEPRECATED_FEATURE_WARNING.error([feature]); The error/warning information should not be ...

8 years, 1 month ago (2012-11-19 08:37:22 UTC) #8

ahe

8 years, 1 month ago (2012-11-19 08:42:10 UTC) #9

Thank you for taking a look, Johnni!

https://codereview.chromium.org/11416004/diff/12016/dart/sdk/lib/_internal/co...
File dart/sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/11416004/diff/12016/dart/sdk/lib/_internal/co...
dart/sdk/lib/_internal/compiler/implementation/compiler.dart:782: :
MessageKind.DEPRECATED_FEATURE_WARNING.error([feature]);
On 2012/11/19 08:37:22, Johnni Winther wrote:
> The error/warning information should not be redundantly put in both the
message
> kind and the [kind] value.

I would like to have a better API, but in general, I'm not sure that kind and
message are redundant.  It is tied to what we should print.  This depends on
user studies, and on localization.

Expand Messages | Collapse Messages