Add a tool to publish packages in the repo to pub.

Add a tool to publish packages in the repo to pub.
Committed: https://code.google.com/p/dart/source/detail?r=15490

[Bob Nystrom, 2012-11-29 00:59:13]

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py
File tools/publish_pkg.py (right):

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:18: saves them back out. subs should by a list of (pattern,
replace) tuples.'''
"by" -> "be"

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:29: def readVersion(file, field):
"ReadVersion" to be consistent with other function names?

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:61: pubspec.write('version: ' + version + '\n')
How about only doing this only if the pubspec doesn't already have a version?
That way we can roll hand-maintained versions in and the script will still work.

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:68: if '.svn' in dirs:
Pub should do this itself. Filed a bug:
http://code.google.com/p/dart/issues/detail?id=7017

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:76: subprocess.call(['pub', 'publish', os.path.join(tmpDir,
pkgName)])
Pub doesn't take a path to the package. Instead, it assumes its the CWD. You'll
need to set that when you spawn the process.

[Bob Nystrom, 2012-11-29 01:04:58]

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py
File tools/publish_pkg.py (right):

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:68: if '.svn' in dirs:
On 2012/11/29 00:59:13, Bob Nystrom wrote:
> Pub should do this itself. Filed a bug:
> http://code.google.com/p/dart/issues/detail?id=7017

Actually, I didn't give Nathan enough credit. It should already handle this.

[Jennifer Messerly, 2012-11-29 01:07:05]

I think my comments are mostly duplicate of Bob's. Doh :)

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py
File tools/publish_pkg.py (right):

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newcode1
tools/publish_pkg.py:1: #!/usr/bin/env python
copyright after this line?

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:20: contents = open(path).read()
It's usually considered good practice to call .close(), though the refcount GC
probably will do it soon enough here.

(if we can assume newer Pythons, you could also use "with" to auto-close it,
including if an exception happens)

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:29: def readVersion(file, field):
would be good to be consistent about UpperCamelCase vs lowerCamelCase.

(official Python style is lower_case_with_underscores but it looks like the Dart
repository is doing the UpperCamelCase for some reason.)

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:66: # Delete .svn directories, replace '../*/pkg' imports
and parts.
Ideally we could delete any file that is not in source control. (or conversely
only copy things *not* in src control)

Does SVN have an equivalent of "git ls-files"? that's what we've been using in
our upload scripts to ensure we don't get any non-src control files.

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:68: if '.svn' in dirs:
according to Nathan, pub will already ignore "." files if you aren't in a git
repository

[dgrove, 2012-11-29 01:14:22]

PTAL

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py
File tools/publish_pkg.py (right):

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newcode1
tools/publish_pkg.py:1: #!/usr/bin/env python
On 2012/11/29 01:07:05, John Messerly wrote:
> copyright after this line?

Done.

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:18: saves them back out. subs should by a list of (pattern,
replace) tuples.'''
On 2012/11/29 00:59:13, Bob Nystrom wrote:
> "by" -> "be"

Done.

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:20: contents = open(path).read()
On 2012/11/29 01:07:05, John Messerly wrote:
> It's usually considered good practice to call .close(), though the refcount GC
> probably will do it soon enough here.
> 
> (if we can assume newer Pythons, you could also use "with" to auto-close it,
> including if an exception happens)

Done.

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:29: def readVersion(file, field):
On 2012/11/29 01:07:05, John Messerly wrote:
> would be good to be consistent about UpperCamelCase vs lowerCamelCase.
> 
> (official Python style is lower_case_with_underscores but it looks like the
Dart
> repository is doing the UpperCamelCase for some reason.)

Done.

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:61: pubspec.write('version: ' + version + '\n')
On 2012/11/29 00:59:13, Bob Nystrom wrote:
> How about only doing this only if the pubspec doesn't already have a version?
> That way we can roll hand-maintained versions in and the script will still
work.

Done.

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:66: # Delete .svn directories, replace '../*/pkg' imports
and parts.
Not that I know of. For now, pub will ignore .svn, so I got rid of that.
On 2012/11/29 01:07:05, John Messerly wrote:
> Ideally we could delete any file that is not in source control. (or conversely
> only copy things *not* in src control)
> 
> Does SVN have an equivalent of "git ls-files"? that's what we've been using in
> our upload scripts to ensure we don't get any non-src control files.

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:68: if '.svn' in dirs:
On 2012/11/29 01:07:05, John Messerly wrote:
> according to Nathan, pub will already ignore "." files if you aren't in a git
> repository

Done.

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:68: if '.svn' in dirs:
On 2012/11/29 01:07:05, John Messerly wrote:
> according to Nathan, pub will already ignore "." files if you aren't in a git
> repository

Done.

https://codereview.chromium.org/11415191/diff/2001/tools/publish_pkg.py#newco...
tools/publish_pkg.py:76: subprocess.call(['pub', 'publish', os.path.join(tmpDir,
pkgName)])
On 2012/11/29 00:59:13, Bob Nystrom wrote:
> Pub doesn't take a path to the package. Instead, it assumes its the CWD.
You'll
> need to set that when you spawn the process.

Done.

[Jennifer Messerly, 2012-11-29 01:19:00]

lgtm

[Bob Nystrom, 2012-11-29 01:23:00]

LGTM.