Issue 11415184: Adding @domName annotations to impl files what were missing them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11415184: Adding @domName annotations to impl files what were missing them. (Closed)

Created:
8 years ago by blois

Modified:
8 years ago

Reviewers:
Andrei Mouravski, Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding @domName annotations to impl files what were missing them. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15462

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -3 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	29 chunks	+29 lines, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	23 chunks	+23 lines, -1 line	0 comments	Download
M	sdk/lib/html/templates/html/dart2js/impl_AudioBufferSourceNode.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/dart2js/impl_Console.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/dart2js/impl_LocalWindow.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/dart2js/impl_MouseEvent.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/dart2js/impl_SelectElement.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/dart2js/impl_TableElement.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/dart2js/impl_Url.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/dartium/impl_LocalWindow.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
	sdk/lib/html/templates/html/dartium/impl_MouseEvent.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_AudioContext.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_CSSStyleDeclaration.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_CanvasElement.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_CustomEvent.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_Document.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_DocumentFragment.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_Element.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_Event.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
	sdk/lib/html/templates/html/impl/impl_EventTarget.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_HtmlDocument.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_HttpRequest.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_IDBKeyRange.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_MutationObserver.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_Node.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_Point.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_ShadowRoot.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_Storage.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_SvgElement.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_SvgSvgElement.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_Text.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_WebSocket.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_WheelEvent.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Andrei Mouravski

8 years ago (2012-11-28 19:39:45 UTC) #3

Message was sent while issue was closed.

lgtm

So, is it recommended that people write docs for these members/classes within
these files? As opposed to @docsEditable?

Expand Messages | Collapse Messages