Port intrisification of setIndexed on Uint8 and Int8 arrays from ia32 to x64.

Port intrisification of setIndexed on Uint8 and Int8 arrays from ia32 to x64.

This is a direct port of the ia32 intrinsifier. We noticed this was
missing when looking at HTTP benchmark profiles.

R=fschneider@google.com,srdjan@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=15261

[Florian Schneider, 2012-11-22 14:35:52]

LGTM with comments.

https://codereview.chromium.org/11415116/diff/1/runtime/vm/intrinsifier_x64.cc
File runtime/vm/intrinsifier_x64.cc (right):

https://codereview.chromium.org/11415116/diff/1/runtime/vm/intrinsifier_x64.c...
runtime/vm/intrinsifier_x64.cc:481: // Move R12 into RDI.
This comment is not very useful. I suggest removing all trivial comments to make
the code more readable and maintainable.

https://codereview.chromium.org/11415116/diff/1/runtime/vm/intrinsifier_x64.c...
runtime/vm/intrinsifier_x64.cc:484: __ movq(R12, Address(RSP, + 1 * kWordSize));
 // Value.
Maybe use a different register than R12 vor the value, so that you don't need to
copy the index first.

https://codereview.chromium.org/11415116/diff/1/runtime/vm/intrinsifier_x64.c...
runtime/vm/intrinsifier_x64.cc:513: // Move R12 into RDI.
Same comments as for Int8Array.

[Florian Schneider, 2012-11-22 14:38:53]

While you're at it, could you clean up the ia32 version as well?

On 2012/11/22 14:35:52, Florian Schneider wrote:
> LGTM with comments.
> 
> https://codereview.chromium.org/11415116/diff/1/runtime/vm/intrinsifier_x64.cc
> File runtime/vm/intrinsifier_x64.cc (right):
> 
>
https://codereview.chromium.org/11415116/diff/1/runtime/vm/intrinsifier_x64.c...
> runtime/vm/intrinsifier_x64.cc:481: // Move R12 into RDI.
> This comment is not very useful. I suggest removing all trivial comments to
make
> the code more readable and maintainable.
> 
>
https://codereview.chromium.org/11415116/diff/1/runtime/vm/intrinsifier_x64.c...
> runtime/vm/intrinsifier_x64.cc:484: __ movq(R12, Address(RSP, + 1 *
kWordSize));
>  // Value.
> Maybe use a different register than R12 vor the value, so that you don't need
to
> copy the index first.
> 
>
https://codereview.chromium.org/11415116/diff/1/runtime/vm/intrinsifier_x64.c...
> runtime/vm/intrinsifier_x64.cc:513: // Move R12 into RDI.
> Same comments as for Int8Array.

[Mads Ager (google), 2012-11-22 14:55:54]

PTAL

I removed the needless move of the index on x64. The reason for the move on ia32
is that we want a byte register. Added a comment to that effect and removed to
trivial comments.

Is this the level of comments you would like to see?

[Florian Schneider, 2012-11-22 14:59:46]

LGTM. Thanks!

[srdjan, 2012-11-22 17:20:55]

lgtm