Issue 11415115: Handle null in augmentField

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11415115: Handle null in augmentField (Closed)

Created:
8 years, 1 month ago by polux

Modified:
8 years ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle null in augmentField Committed: https://code.google.com/p/dart/source/detail?r=15508

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart	View		1 chunk	+5 lines, -3 lines	0 comments	Download
	M	tests/compiler/dart2js/cpa_inference_test.dart	View		2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM for this change, but a general question: since we know that everything after [:null.x:] ...

8 years ago (2012-11-28 08:06:38 UTC) #2

polux

8 years ago (2012-11-29 10:23:16 UTC) #3

On 2012/11/28 08:06:38, karlklose wrote:
> LGTM for this change, but a general question: since we know that everything
> after [:null.x:] is dead code, should the result be [] for all of the
variables?

Good point, that's an optimization I'll keep in mind.

Expand Messages | Collapse Messages