Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 11415105: Eliminate explicit abstract from class members in tests (Closed)

Created:
8 years, 1 month ago by hausner
Modified:
8 years, 1 month ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Eliminate explicit abstract from class members in tests Committed: https://code.google.com/p/dart/source/detail?r=15220

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -26 lines) Patch
M tests/language/abstract_factory_constructor_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/abstract_getter_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/abstract_syntax_test.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests/language/bad_constructor_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/language/external_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/get_set_syntax_test.dart View 1 2 chunks +0 lines, -4 lines 0 comments Download
M tests/language/implicit_this_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/interface_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/property_field_override_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/typed_selector_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/testing_server.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
8 years, 1 month ago (2012-11-21 19:29:48 UTC) #1
regis
LGTM But I would have added '// Abstract.' where you removed the keyword, to make ...
8 years, 1 month ago (2012-11-21 19:51:20 UTC) #2
hausner
8 years, 1 month ago (2012-11-21 20:14:18 UTC) #3
Added comments as suggested.

Powered by Google App Engine
This is Rietveld 408576698