Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 11415076: Removing Window.blur() and Window.focus(). This time for real. (Closed)

Created:
8 years, 1 month ago by Andrei Mouravski
Modified:
8 years, 1 month ago
Reviewers:
vsm, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removing Window.blur() and Window.focus(). This time for real. See: dev.w3.org/html5/spec/editing.html#document-level-focus-apis Committed: https://code.google.com/p/dart/source/detail?r=15176

Patch Set 1 #

Patch Set 2 : Testing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -32 lines) Patch
sdk/lib/html/dart2js/html_dart2js.dart View 4 chunks +0 lines, -12 lines 0 comments Download
sdk/lib/html/dartium/html_dartium.dart View 4 chunks +0 lines, -12 lines 0 comments Download
sdk/lib/html/scripts/htmlrenamer.py View 1 chunk +2 lines, -0 lines 0 comments Download
sdk/lib/html/src/CrossFrameTypes.dart View 1 chunk +0 lines, -2 lines 0 comments Download
sdk/lib/html/src/dart2js_DOMImplementation.dart View 1 chunk +0 lines, -4 lines 0 comments Download
sdk/lib/html/src/native_DOMImplementation.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Andrei Mouravski
Trying again. I had forgotten to remove the code from places that implemented Window.
8 years, 1 month ago (2012-11-20 18:57:20 UTC) #1
blois
lgtm
8 years, 1 month ago (2012-11-20 19:00:06 UTC) #2
vsm
8 years, 1 month ago (2012-11-20 20:26:04 UTC) #3
lgtm

Do you plan to remove from Element and DocumentFragment as well?

Powered by Google App Engine
This is Rietveld 408576698