Issue 11415048: Deserialize same symbol as same Dart_CObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11415048: Deserialize same symbol as same Dart_CObject (Closed)

Created:
8 years, 1 month ago by Søren Gjesse

Modified:
8 years, 1 month ago

Reviewers:
Florian Schneider, Mads Ager (google)

CC:
reviews_dartlang.org, cshapiro, Florian Schneider

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Deserialize same symbol as same Dart_CObject When symbols are deserialized as part of a Dart_CObject the same symbols are now turned into the same Dart_CObject objects. R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15082

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -4 lines)			Patch
M	runtime/vm/dart_api_message.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart_api_message.cc	View	2 chunks	+21 lines, -2 lines	2 comments	Download
M	runtime/vm/snapshot_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

dbc: https://chromiumcodereview.appspot.com/11415048/diff/1/runtime/vm/dart_api_message.cc File runtime/vm/dart_api_message.cc (right): https://chromiumcodereview.appspot.com/11415048/diff/1/runtime/vm/dart_api_message.cc#newcode230 runtime/vm/dart_api_message.cc:230: #ifdef DEBUG I think you need to zero-initialize ...

8 years, 1 month ago (2012-11-19 14:30:08 UTC) #3

Søren Gjesse

8 years, 1 month ago (2012-11-19 14:54:46 UTC) #4

https://chromiumcodereview.appspot.com/11415048/diff/1/runtime/vm/dart_api_me...
File runtime/vm/dart_api_message.cc (right):

https://chromiumcodereview.appspot.com/11415048/diff/1/runtime/vm/dart_api_me...
runtime/vm/dart_api_message.cc:230: #ifdef DEBUG
On 2012/11/19 14:30:08, Florian Schneider wrote:
> I think you need to zero-initialize this array in any case.

Absolutely, thanks for spotting.

Expand Messages | Collapse Messages